Jump to content

Torches Ignite Oil (by Thurderan)

TechAngel85

By TechAngel85
in Skyrim SE Mods

 Share

Recommended Posts

  • 3 years later...
CorneliusC Jarl

CorneliusC

Posted
Posted

Hi. This mod consists of one esp, which modifies two different records in 'FormId List'. These modifications/additions of spells to each record are then forwarded into the 'Step Patch - Conflict Resolution', along with other entries to the same records made by USCCCP and AOS. Since this mod, 'Torches Ignite Oil' has all its entries forwarded into the Step patch and does not create any new records of its own to refer to, would this not make this plugin/esp obsolete?

TrapGasOnEnter.thumb.jpg.c6acde10b0e90d05d0ff12d61dc1cb93.jpg TrapGasOnHit.thumb.jpg.23dca0b0c74dd04d37cd7b5ade16bb55.jpg

  • Like 1
Mousetick Emperor

Mousetick

Posted
Posted
  On 9/28/2023 at 2:00 PM, CorneliusC said:

Since this mod, 'Torches Ignite Oil' has all its entries forwarded into the Step patch and does not create any new records of its own to refer to, would this not make this plugin/esp obsolete?

Expand  

It makes it redundant yes. This mod's plugin could be removed. It would make the load order simpler to install for users and lighter. But doing so creates new problems for the STEP maintainers. The same issue exists for anything that already is, or could be, incorporated into the STEP Patch(es), such as the recently discussed Lucien Lachance AE.

First there is the question of permissions. Does the mod author allow integrating their changes into another mod or plugin, and redistributing that?

Assuming the permissions allow it, incorporating small changes directly into CR Patches creates a long-term maintenance nightmare for the STEP Patch maintainers. Once the original mod plugin is removed from the load order, it's impossible to tell the origin of the changes in the CR Patch. If you look at the patch a few months from now, you can immediately see the merged changes from other plugins, but you'll likely be wondering what the heck are these torch things (from this mod) doing in the FormList. Or if you're rebuilding the CR Patch from scratch, the incorporated changes will be lost because they didn't appear separately in the load order.

To prevent these issues, I use this method, FWIW:

  • I have a custom plugin dedicated to incorporating small changes from various mods. It's called 'Miscellaneous.esp'.
  • If there is mod that I like and want to keep, but it makes trivial changes into a tiny plugin, I merge it in to Miscellaneous.esp.
  • I keep a list of all the mods that are merged into Miscellaneous.esp.
  • Miscellaneous.esp is included in my load order, obviously.
  • My CR patch(es) exclusively contain conflict resolutions, including with Miscellaneous.esp which changes appear on their own in xEdit.
  • It's clear and there is no ambiguity as to where the changes in the CR Patch(es) come from.

Hope this helps.

My notes for Miscellaneous.esp:

  Reveal hidden contents

That's about 90 plugins combined into one.

  • Like 1
TechAngel85 Akatosh

TechAngel85

Posted
  • Author
Posted
  On 9/28/2023 at 2:47 PM, Mousetick said:

... But doing so creates new problems for the STEP maintainers. The same issue exists for anything that already is, or could be, incorporated into the STEP Patch(es), such as the recently discussed Lucien Lachance AE.

First there is the question of permissions. Does the mod author allow integrating their changes into another mod or plugin, and redistributing that?

Expand  

Yes and no.

Our view on permissions with nothing but simple plugin edits is this:
It's ridiculous to think anyone could "own" such small edits that anyone could stumble upon and make themselves. When permissions are closed on such mods, we simply recreate them from scratch; thus, incorporating them.

In the case of this mod, anyone looking at these lists in CK/xEdit could reasonably assume adding additional references/spells to the list would cause them to do the same thing the originals do. It's basic logic and reasoning so I have no issues just recreating the edits within the Patch from scratch to bypass any permissions (which are not set on this mod's page).

Lucien mod is a different story as it wasn't simple changes, but stylistic changes to realign that NPC to his Oblivion counterpart. This goes beyond simple plugin changes and would need permissions to be incorporated.
 

  On 9/28/2023 at 2:47 PM, Mousetick said:

Assuming the permissions allow it, incorporating small changes directly into CR Patches creates a long-term maintenance nightmare for the STEP Patch maintainers. Once the original mod plugin is removed from the load order, it's impossible to tell the origin of the changes in the CR Patch. If you look at the patch a few months from now, you can immediately see the merged changes from other plugins, but you'll likely be wondering what the heck are these torch things (from this mod) doing in the FormList. Or if you're rebuilding the CR Patch from scratch, the incorporated changes will be lost because they didn't appear separately in the load order.

Expand  

No, not really the case. We have a Patch Reference we can use for such things. Granted it may or may not have been upkept since I stopped working on the SE Guide to focus on other things. It does look I was the last to edit it, but I can't control what the other staff chooses to maintain or not.

z929669 Akatosh

z929669

Posted
Posted

I think Lucien's stylistic change is also possible to conceive with out that MA doing it first. I only consider something totally unique to require permissions (like brand new records or references). I have yet to inspect Lucien's though, so can't say for sure.

The changelog details changes to masters, but I didn't take the time to reference every little thing, because most of the work I've done is remove redundancies rather than add new changes to the patches. I'll be taking a closer look in the coming weeks (referencing several posts from the Feedback topic), but no time at present.

We also use Git, so nothing is really lost. Spriggin will make that even more robust.

Sooo much housekeeping to catch up on for several guides now.

TechAngel85 Akatosh

TechAngel85

Posted
  • Author
Posted
  On 9/29/2023 at 4:10 AM, z929669 said:

Sooo much housekeeping to catch up on for several guides now.

Expand  

Agree. As I'm going through some of the miscellaneous wiki content that isn't updated very often, I'm finding quite a bit that needs addressing. A pint to the good ol'days when we had a lot more staff for upkeep! :silly:

CorneliusC Jarl

CorneliusC

Posted
Posted

Interesting topics, thank you for this.

With this mod's esp now being clear as being redundant with the 'Step Patch - Conflict Resolution', i will go ahead and deactivate the esp, but keep the mod installed as a reference point.

Following the logic of this mod, might i suggest to maybe consider using the third of the mod's main files, 'Torches Ignite Oil - Shock Edition Arcane Archer Pack Compatibility', which adds shock and fire arrows to the 'TrapGasOnHit' record? USCCCP is already adding fire arrows to the record, so entry of the shock arrows would make the whole behaviour more consistent.

  • Like 1
z929669 Akatosh

z929669

Posted
Posted
  On 9/29/2023 at 1:01 PM, CorneliusC said:

Interesting topics, thank you for this.

With this mod's esp now being clear as being redundant with the 'Step Patch - Conflict Resolution', i will go ahead and deactivate the esp, but keep the mod installed as a reference point.

Following the logic of this mod, might i suggest to maybe consider using the third of the mod's main files, 'Torches Ignite Oil - Shock Edition Arcane Archer Pack Compatibility', which adds shock and fire arrows to the 'TrapGasOnHit' record? USCCCP is already adding fire arrows to the record, so entry of the shock arrows would make the whole behaviour more consistent.

Expand  

This makes sense to me.

  • 6 months later...
TechAngel85 Akatosh

TechAngel85

Posted
  • Author
Posted

Since we're disabling the plugin from the mod, it's completely redundant to have it listed in the Guide. I say we ensure the Guide Patch is covering this completely as we desire and then simply remove the mod from the Guide for the next update.

  • 3 months later...

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...

Important Information

By using this site, you agree to our Guidelines, Privacy Policy, and Terms of Use.

  I accept